Skip to content

Commit

Permalink
Inline chat UI contains undesired empty space after getting response
Browse files Browse the repository at this point in the history
  • Loading branch information
aeschli committed Nov 21, 2023
1 parent 633efd8 commit 58df6c8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/vs/workbench/contrib/chat/browser/media/chat.css
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@

.interactive-item-container.interactive-item-compact.no-padding {
padding: unset;
gap: unset;
}

.interactive-item-container.interactive-item-compact .header {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -588,9 +588,10 @@ export class InlineChatWidget {
updateChatMessage(message: IInlineChatMessage | undefined): void;
updateChatMessage(message: IInlineChatMessage | undefined, isIncomplete?: boolean): IInlineChatMessageAppender | undefined {
this._chatMessageDisposables.clear();
this._elements.chatMessage.classList.toggle('hidden', !message);
const hasMessage = message?.message.value;
this._elements.chatMessage.classList.toggle('hidden', !hasMessage);
reset(this._elements.chatMessageContent);
if (message) {
if (hasMessage) {
const sessionModel = this._chatMessageDisposables.add(new ChatModel(message.providerId, undefined, this._logService, this._chatAgentService));
const responseModel = this._chatMessageDisposables.add(new ChatResponseModel(message.message, sessionModel, undefined, message.requestId, !isIncomplete, false, undefined));
const viewModel = this._chatMessageDisposables.add(new ChatResponseViewModel(responseModel, this._logService));
Expand Down

0 comments on commit 58df6c8

Please sign in to comment.