make indexedDB tests faster #149737
Merged
make indexedDB tests faster #149737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove unnecessary validations - group writes
JacksonKearl
approved these changes
May 17, 2022
wannieman98
pushed a commit
to wannieman98/vscode
that referenced
this pull request
May 17, 2022
…impet make indexedDB tests faster
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #149712
Before
After
Cannot be made faster than above because the bottle neck is IndexedDB. Any write transaction in IndexedDB is taking ~20ms and couple of tests need at least 2-3 write transactions.