Fix restoration of problems (from watch task) when closing a file #183172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47386
Logic was added in df97bc3 to add a watcher's problems back to the problems view after closing a file.
It doesn't work quite right though because of howprocessLineInternal
batches up changes, only sending them tomarkerService
when it gets called on subsequent lines with a different owner or resource.Because of that, the current behavior is that when you close a file with errors, the errors will disappear and only end up getting restored the next time a different file being watched gets saved.
This PR fixes that (restoring the errors right after the file is closed) by calling
forceDelivery()
.cc @alexr00