-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync xterm's textarea with buffer contents #190294
Conversation
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
@Tyriar mostly working now, except if I do textarea.mov
|
surprising errors given I didn't change this line 🤔 vscode/src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts Lines 14 to 16 in e151ba5
|
src/vs/workbench/contrib/terminal/browser/xterm/textAreaSyncAddon.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/xterm/textAreaSyncAddon.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/xterm/textAreaSyncAddon.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/accessibility/browser/textAreaSyncAddon.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after the couple of comments
Not sure about the monaco check failure, @hediet do you know why it thinks platform/terminal is part of monaco?
src/vs/workbench/contrib/terminalContrib/developer/browser/terminal.developer.contribution.ts
Outdated
Show resolved
Hide resolved
...rkbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
Outdated
Show resolved
Hide resolved
…/terminal.accessibility.contribution.ts Co-authored-by: Daniel Imms <[email protected]>
fixes #186904