Making TypeScript code actions move to new file and move to appear less often
#198775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit bc4dc88 Author: Aiday Marlen Kyzy <[email protected]> Date: Tue Nov 21 13:07:39 2023 +0100 adding one more possibility which is lightbulb sparkle and auto-fix commit a5dfa1f Author: Aiday Marlen Kyzy <[email protected]> Date: Tue Nov 21 12:55:44 2023 +0100 removing one because should be using zero based ranges commit 78b29c0 Author: Aiday Marlen Kyzy <[email protected]> Date: Tue Nov 21 12:49:50 2023 +0100 using the navTree request instead commit ba1b8fe Author: Aiday Marlen Kyzy <[email protected]> Date: Tue Nov 21 12:20:38 2023 +0100 polishing the code commit 5ae767f Author: Aiday Marlen Kyzy <[email protected]> Date: Tue Nov 21 12:14:35 2023 +0100 polishing the code commit fd347bb Author: Aiday Marlen Kyzy <[email protected]> Date: Tue Nov 21 11:03:04 2023 +0100 remembering the class array that was previously set, so not removing the whole class array commit fd5fd11 Author: Aiday Marlen Kyzy <[email protected]> Date: Tue Nov 21 10:54:18 2023 +0100 using the appropriate icon commit df29259 Merge: 5285e1d 633efd8 Author: Aiday Marlen Kyzy <[email protected]> Date: Tue Nov 21 10:47:18 2023 +0100 Merge branch 'main' into aiday/differentLightBulbDependingOnCodeAction commit 5285e1d Author: Aiday Marlen Kyzy <[email protected]> Date: Mon Nov 20 18:24:45 2023 +0100 making the filtering function synchronous commit a86c36c Author: Aiday Marlen Kyzy <[email protected]> Date: Mon Nov 20 17:42:11 2023 +0100 adding code in order to also include move to a new file only when on the range of interest commit 2cedc2f Author: Aiday Marlen Kyzy <[email protected]> Date: Mon Nov 20 17:11:13 2023 +0100 not showing move to file all the time commit 8f4ade1 Author: Aiday Marlen Kyzy <[email protected]> Date: Mon Nov 20 14:50:56 2023 +0100 removing the code which does the selection check commit 2e0e6c5 Author: Aiday Marlen Kyzy <[email protected]> Date: Mon Nov 20 14:31:55 2023 +0100 adding code in order to execute the AI code action when it is unique commit a037c7e Author: Aiday Marlen Kyzy <[email protected]> Date: Mon Nov 20 14:05:32 2023 +0100 adding code in order to be able to detect when different code actions partitions appear commit abd005b Author: Aiday Marlen Kyzy <[email protected]> Date: Fri Nov 17 18:07:26 2023 +0100 changing the heuristic of the move to code actions commit e4886ea Author: Aiday Marlen Kyzy <[email protected]> Date: Fri Nov 17 17:25:57 2023 +0100 removing model commit 79102a9 Author: Aiday Marlen Kyzy <[email protected]> Date: Fri Nov 17 17:25:48 2023 +0100 making lightbub icon appear on empty lines commit ee8bb34 Author: Aiday Marlen Kyzy <[email protected]> Date: Fri Nov 17 17:09:15 2023 +0100 directly resolving the code action when it is an ai code action commit 4d4bcb9 Author: Aiday Marlen Kyzy <[email protected]> Date: Fri Nov 17 17:02:34 2023 +0100 wip allow lightbulb menu to specify different icons depending on the code actions
|
cc @mjbvz regarding microsoft/TypeScript#56416 too |
aeschli
reviewed
Nov 22, 2023
extensions/typescript-language-features/src/languageFeatures/refactor.ts
Outdated
Show resolved
Hide resolved
aeschli
approved these changes
Nov 22, 2023
aiday-mar
added a commit
that referenced
this pull request
Nov 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to the PR on changing the lightbulb menu