testing: initial test coverage UI #198812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This continues on the coverage API I started a few years ago. It adds initial integration where a "Show Test Coverage" tree item is shown in the Test Results view, which then opens a dedicated Test Coverage view. The Test Coverage view is a fairly basic tree view following the draft design, with further improvements to come. The 'bars' widget is also built in a reusable way such that it can be integrated into the explorer, as this was a popular ask both inside and outside the team. For #123713.
connor4312
force-pushed
the
connor4312/testing-coverage-view
branch
from
1094b15 to
e09bee7
Compare
rzhao271
reviewed
Nov 22, 2023
| TestingDisplayedCoveragePercent.Minimum, | ||
| ], | ||
| enumDescriptions: [ | ||
| localize('testing.displayedCoveragePercent.totalCoverage', 'A calculate of the combined statement, function, and branch coverage.'), |
There was a problem hiding this comment.
"A combination of" instead of "A calculate of"?
rzhao271
reviewed
Nov 22, 2023
| /** @inheritdoc */ | ||
| public renderCompressedElements(node: ITreeNode<ICompressedTreeNode<CoverageTreeElement>, FuzzyScore>, _index: number, templateData: TemplateData): void { | ||
| const chain = node.element.elements; | ||
| const lastElement = chain[chain.length - 1]; |
There was a problem hiding this comment.
Is an empty array check needed?
There was a problem hiding this comment.
no, the tree won't render compressed elements where the elements are empty
rzhao271
previously approved these changes
Nov 22, 2023
rzhao271
approved these changes
Nov 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues on the coverage API I started a few years ago. It adds initial integration where a "Show Test Coverage" tree item is shown in the Test Results view, which then opens a dedicated Test Coverage view. The Test Coverage view is a fairly basic tree view following the draft design, with further improvements to come.
The 'bars' widget is also built in a reusable way such that it can be integrated into the explorer, as this was a popular ask both inside and outside the team.
For #123713.