Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background DSC classes for personalization #145

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Jan 10, 2025


This PR addresses issue #97. It contains the following new DSC classes:

  • BackgroundPicture
  • BackgroundSolidColor
  • BackgroundSlideshow
  • BackgroundWindowsSpotlight
Microsoft Reviewers: Open in CodeFlow

@Gijsreyn
Copy link
Contributor Author

@denelon and @ryfu-msft, I thought of giving this one a go, but I ended up stumbling on an endless tour of scavenging through C# code. The BackgroundPicture, BackgroundSolidColor and BackgroundWindowsSpotlight should work on all OSes. However, when looking at the BackgroundSlideShow, it doesn't. I already pre-populated some functions to determine the OS it supports.

The most challenging part, which I couldn't solve, is this:

image

I searched the internet, and I saw a ton of workarounds to get the slideshow to work, all with their pros and cons, which are not very applicable for a DSC resource. I couldn't encrypt and decrypt this value correctly. If you have any suggestions, please let me know.

P.S. I'll update the issue with the remaining work.

@denelon
Copy link
Contributor

denelon commented Jan 13, 2025

@Gijsreyn, I'm playing catchup from being OOF last week. Also, ryfu is no longer at MSFT 😢. We'll have some other engineers joining in the fray here 😊.

@Gijsreyn
Copy link
Contributor Author

Cool, that's a pity to hear 😢, but at the same time, looking forward to the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants