Skip to content

Commit

Permalink
Use a sr-only span rather than the title attribute to include text in…
Browse files Browse the repository at this point in the history
… the footer social links. For #177.
  • Loading branch information
imcbride committed Jul 23, 2019
1 parent c0ed0d1 commit 03ca44c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/templates/partials/footer.twig
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
<li class="social-links__item">
<a href="{{item.href}}" class="social-links__link">
{% include 'partials/icon.twig' with {
'name': 'item.slug',
'title': 'item.text'
'name': 'item.slug'
} %}
<span class="sr-only">{{item.text}}</span>
</a>
</li>
{% endfor %}
Expand Down
1 change: 0 additions & 1 deletion src/templates/partials/icon.twig
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
<svg class="icon {{class}} {% if size %}icon--{{size}}{% endif %}" focusable="false" aria-hidden="true">
{% if title %}<title>{{title}}</title>{% endif %}
<use xlink:href="#icon-{{name}}">
</svg>

0 comments on commit 03ca44c

Please sign in to comment.