Lexer options don't get passed to lexer #92
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made:
Fixed the core issue in
/lib/middleman-syntax/highlighter.rb
:lexer_options
fromhighlighter_options
before callingfind_fancy()
lexer_options
as the third parameter toRouge::Lexer.find_fancy()
lexer_options
parameter fromlexer.lex()
call (which was causing deprecation warnings)Added comprehensive test in
/features/lexer_options.feature
:myshell>>>
is parsed as single prompt instead ofmyshell>
+>>
operatorUpdated step definitions in
/features/support/step_definitions.rb
:Updated
.gitignore
:vendor/bundle
to exclude bundled dependenciesTechnical Details:
The issue was that
lexer_options
were being extracted from the configuration but only passed tolexer.lex()
, which doesn't accept options (causing deprecation warnings). The Rouge API requires lexer options to be passed toRouge::Lexer.find_fancy()
as the third parameter to properly configure the lexer instance.Test Results:
Fixes #72.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.