Skip to content

Changed HTML comments to JSX comments. #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nachomata
Copy link

This pull request changes the HTML comments in AboutMe.astro component to JS comments.

As explained in the astro documentation, HTML-style comments will be included in browser DOM, while JS ones will be skipped.

In the live page https://porfolio.dev the HTML comments can be seen in the source code of the page.

image

With this change, comments are not shown in the build.

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for animated-churros-60739d ready!

Name Link
🔨 Latest commit c9a0eaa
🔍 Latest deploy log https://app.netlify.com/sites/animated-churros-60739d/deploys/67918d94ea41380008e9c88a
😎 Deploy Preview https://deploy-preview-77--animated-churros-60739d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant