Add Installation instructions to README.md #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credit goes to @astradamus for the installation instructions
lethosor
suggested changes
Jun 7, 2017
| ## Installation ## | ||
| All file paths are relative to your dwarf fortress installation directory | ||
| 1. Override any conflicts presented by the following steps. | ||
| 2. Extract all .dll/.so/.dylib files to `hack/plugins`. If your package includes multiple sets of these libraries, make your best guess as to which is newest (betas tend to come after alphas, higher numbers imply newer versions, etc.) and use that one. |
There was a problem hiding this comment.
You should use whatever version corresponds to your DFHack version, or it won't work at all.
There was a problem hiding this comment.
Appreciate the credit, but yeah those directions were less 'production ready' and more 'flying by the seat of my pants'.
|
Well if you have any suggestions, feel free to make them. I just figured
having something on the readme was better than nothing at all, and it was
an easy fix
…On Thu, Jun 8, 2017 at 9:22 PM Alexander Strada ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#58 (comment)>:
> @@ -8,6 +8,14 @@ Originally I wrote a small plugin because I was tired seeing coffins instead of
+## Installation ##
+All file paths are relative to your dwarf fortress installation directory
+1. Override any conflicts presented by the following steps.
+2. Extract all .dll/.so/.dylib files to `hack/plugins`. If your package includes multiple sets of these libraries, make your best guess as to which is newest (betas tend to come after alphas, higher numbers imply newer versions, etc.) and use that one.
Appreciate the credit, but yeah those directions were less 'production
ready' and more 'flying by the seat of my pants'.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#58 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AG_ZN5lty_1DpOd9vJiDYmmqyv-7IoXjks5sCMhvgaJpZM4NyQMh>
.
|
|
Don't disagree, only meant that it would be good to get some kind of official confirmation that my instructions are correct before making them official docs, because I was winging it and it worked for me-- I didn't test it with any other setups, it's entirely possible that I described something wrong (as @lethosor indicates). |
|
This should definitely be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit goes to @astradamus for the installation instructions.
Should resolve #12