Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Swift and Godot Signal Syntax #584

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Unify Swift and Godot Signal Syntax #584

wants to merge 23 commits into from

Commits on Nov 7, 2024

  1. suppress formatting for now

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    53966d1 View commit details
    Browse the repository at this point in the history

  2. Generic signal support

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a646da7 View commit details
    Browse the repository at this point in the history

  3. Require macOS 14 for the generic pack support 

    Would bumping the swift-tools-version to 5.10 be better?
    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c8ce59a View commit details
    Browse the repository at this point in the history

  4. Use generic signal instead of generating helper

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    20025c5 View commit details
    Browse the repository at this point in the history

  5. Don't use SimpleSignal

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3f19b01 View commit details
    Browse the repository at this point in the history

  6. Moved GenericSignal to its own file. Removed some unused code, tidied… 

    … comments.
    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    8a9ffda View commit details
    Browse the repository at this point in the history

  7. Fixed popping objects.

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    32ecb25 View commit details
    Browse the repository at this point in the history

  8. Cleaner unpacking, without the need to copy the arguments.

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    cd72ae3 View commit details
    Browse the repository at this point in the history

  9. revert unrelated formatting changes

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a55d63b View commit details
    Browse the repository at this point in the history

  10. put back SignalSupport to minimise changes

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    7cc7603 View commit details
    Browse the repository at this point in the history

  11. Removed SimpleSignal completely

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    7eae04f View commit details
    Browse the repository at this point in the history

  12. tweaked names for a cleaner diff

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    81f13a0 View commit details
    Browse the repository at this point in the history

  13. Added test for built in signals

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2be97a8 View commit details
    Browse the repository at this point in the history

  14. Declare local computed property for each signal. 

    Allows using the spelling obj.signal.connect(target, method) which is closer to GDScript than obj.connect(Class.signal, target, method)
    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    af36fd8 View commit details
    Browse the repository at this point in the history

  15. Added emit method.

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4b75787 View commit details
    Browse the repository at this point in the history

  16. Added #nusignal macro to avoid breaking #signal 

    Should probably deprecate #signal and/or rename #nusignal
    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ed702db View commit details
    Browse the repository at this point in the history

  17. Implemented emit() for GenericSignal

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    14e2273 View commit details
    Browse the repository at this point in the history

  18. removed unused adaptor class

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    97854d4 View commit details
    Browse the repository at this point in the history

  19. removed SimpleSignal

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3a2a8fe View commit details
    Browse the repository at this point in the history

  20. Call registration method for nusignal macro

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f2e86c6 View commit details
    Browse the repository at this point in the history

  21. Signals registering correctly.

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    653f270 View commit details
    Browse the repository at this point in the history

  22. cleaned up

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3ba66f6 View commit details
    Browse the repository at this point in the history

  23. reverted unrelated formatting changes

    @samdeane
    samdeane committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ce226d0 View commit details
    Browse the repository at this point in the history