Miic v210 #136
Draft
Miic v210 #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franck-simon
requested review from
Alich13,
O-mics,
louis-montagne and
Ouahab0097
Alich13
reviewed
Jun 23, 2025
| @@ -490,14 +490,16 @@ jointplot_hist <- function(X, Y, result, nameDist1, nameDist2, | |||
| fill_density_flat[fill_density_flat$density == 0, "density"] <- NA | |||
| fill_density_flat$logdensity = log(fill_density_flat$density) | |||
|
|
|||
| hist2d <- ggplot2::ggplot(fill_density_flat) + | |||
| # with is a bad fix to avoid warnings from ggplot2 or notes from CRAN checks | |||
| # print (paste0 ("nrow: ", nrow (data_loop), | ||
| # ", ncol: ", ncol (data_loop) ) ) | ||
| # | ||
| if ( (nrow (data_loop) > 0) && (ncol (data_loop) > 0) ) |
There was a problem hiding this comment.
Suggested change
| if ( (nrow (data_loop) > 0) && (ncol (data_loop) > 0) ) | |
| if ( (nrow (data_loop) > 0) && (ncol (data_loop) > 1) ) |
If I get it right, if we don't skip the checks above we drop the constant columns ? So theoretically, we might remove all the variables and end up with a data_loop containing 0 or 1 column . When this happens , miic main function crashes because it cannot reconstruct a network from a single variable .
This event becomes more likely when running the last vofs in the list against the remaining variables .And also when working with small size datasets like flash-seq
| #------------------------------------------------------------------------------- | ||
| compute_mi_batch <- function (input_data, | ||
| var_of_interest_names=NULL, var_of_interest_values=NULL, unit="log_conf", | ||
| corrected=T, precomputed_mis=NULL, skip_cheks=F, n_threads=1, verbose=3) |
There was a problem hiding this comment.
NIT : small typo .
Suggested change
| corrected=T, precomputed_mis=NULL, skip_cheks=F, n_threads=1, verbose=3) | |
| corrected=T, precomputed_mis=NULL, skip_checks=F, n_threads=1, verbose=3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split of miic/tmiic
Features selection