Add support for Bosch BME680/688/690 atmospheric + gas sensors #111
Conversation
|
This is ready for review. One change that I implemented that may need discussion is the use of preprocessor commands to enable certain features rather than mapping them to boolean values. GCC didn't do a great job with optimizations if they weren't written as preprocessor commands. |
|
@ke5gdb Thanks for the contribution, this looks mostly good! Did you test the code on all variants of the sensor? We'll probably have to decide on whether we'd use booleans vs preprocessor logic for feature flags and refactor this code a bit. Now it's a bit mixed. |
|
I only tested it on the BMP680 since that's what I have handy (I thought I had a 690, wrote the interface for a 690, and then realized that it got subbed for a 680). It has been well tested (including two flights) with the 680 though. I agree on coming to a decision on boolean vs preprocessor logic. It seems like some optimization just isn't taking place that should allow constant boolean expressions to be factored out as if they were a preprocessor command, but I lack experience in that domain. |
2 participants
No description provided.