Skip to content

Per variant export configuration #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2025
Merged

Conversation

mikepenz
Copy link
Owner

  • add option to configure the export per variant, enabling integrations to configure variants expected

@mikepenz mikepenz requested a review from Copilot April 26, 2025 12:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces per variant export configuration for the about-libraries plugin, allowing integrations to specify variant-specific export options. Key changes include:

  • Updating BaseAboutLibrariesTask to use abstract properties (SetProperty/Property) for export configuration.
  • Modifying AboutLibrariesTask to incorporate variant-specific file naming and file path providers.
  • Extending AboutLibrariesExtension with a new exports container and updating the ExportConfig constructor.

Reviewed Changes

Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.

File Description
plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/BaseAboutLibrariesTask.kt Updated export configuration properties to abstract getters and set them based on variant-specific settings.
plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesTask.kt Introduced providers for file name and output file, allowing for variant-specific configuration overrides.
plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesExtension.kt Added a new exports container and updated the ExportConfig constructor to include a name parameter for variant identification.
Files not reviewed (4)
  • app-test/build.gradle.kts: Language not supported
  • app-test/files/aboutlibraries.json: Language not supported
  • app-test/files/jvm/aboutLibraries.json: Language not supported
  • app-test/files/wasmJs/aboutLibraries.json: Language not supported
Comments suppressed due to low confidence (1)

plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesExtension.kt:423

  • [nitpick] Consider documenting the purpose of the 'name' parameter in ExportConfig or choosing a more descriptive name to clearly indicate its role in variant identification within the exports container.
abstract class ExportConfig @Inject constructor(val name: String = "") {

@mikepenz mikepenz merged commit a41a9de into develop Apr 26, 2025
3 checks passed
@mikepenz mikepenz deleted the feature/register_variant_tasks branch April 26, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants