Skip to content

Fix android task configuration #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

Fix android task configuration #1187

merged 1 commit into from
Jun 6, 2025

Conversation

mikepenz
Copy link
Owner

@mikepenz mikepenz commented Jun 6, 2025

@mikepenz mikepenz requested a review from Copilot June 6, 2025 13:10
@mikepenz mikepenz added the fix label Jun 6, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the Android task registration configuration and updates several version and license details across the project. Key changes include:

  • Disabling the STABLE_CONFIGURATION_CACHE feature preview in settings.gradle.kts.
  • Filtering project configurations in BaseAboutLibrariesTask to only include resolvable ones.
  • Adding an explicit control flow for Android task registration in AboutLibrariesPlugin.
  • Version and license hash updates in various aboutlibraries.json files and disabling Android tasks in app-test/build.gradle.kts.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
settings.gradle.kts Comments out STABLE_CONFIGURATION_CACHE feature preview.
plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/BaseAboutLibrariesTask.kt Updates configuration setting to filter for resolvable configurations.
plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesPlugin.kt Adds conditional logging for Android task registration.
app-test/files/wasmJs/aboutlibraries.json, app-test/files/jvm/aboutlibraries.json, app-test/files/aboutlibraries.json Bumps artifact versions and updates license hashes.
app-test/build.gradle.kts Disables Android task registration through the aboutLibraries android block.
Comments suppressed due to low confidence (4)

plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesPlugin.kt:58

  • Ensure that the new conditional branch with logging for both enabled and disabled Android task registration handles all evaluation scenarios as expected.
if (extension.android.registerAndroidTasks.get()) {

app-test/build.gradle.kts:27

  • Double-check that setting 'registerAndroidTasks' to false in the test configuration aligns with overall integration requirements and does not inadvertently bypass other necessary task registrations.
android { registerAndroidTasks = false }

settings.gradle.kts:4

  • Confirm that commenting out the 'STABLE_CONFIGURATION_CACHE' feature preview is intended, ensuring that no dependencies rely on this preview feature.
// enableFeaturePreview("STABLE_CONFIGURATION_CACHE")

plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/BaseAboutLibrariesTask.kt:154

  • Verify that filtering configurations using 'it.isCanBeResolved' intentionally excludes any configurations needed later in the process.
configurations.set(project.configurations.filter { it.isCanBeResolved })

@mikepenz mikepenz merged commit 51d3edf into develop Jun 6, 2025
3 checks passed
@mikepenz mikepenz deleted the fix/1186 branch June 6, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

registerAndroidTasks = false is ignored
1 participant