-
-
Notifications
You must be signed in to change notification settings - Fork 463
Upgrade to Kotlin 2.2 | Compose 1.8.3 / 1.8.2 | Serialization 1.9.0 #1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mikepenz
commented
Jul 1, 2025
- Kotlin 2.2.0
- Compose 1.8.3 / Compose Multiplatform 1.8.2
- Serialization 1.9.0
- upgrade to a newer convention plugin version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades core library versions and refactors the Gradle plugin surface to introduce an Android-specific plugin and new license-requirement behavior.
- Bump Kotlin, Compose, and Serialization dependencies and convention plugin versions
- Split the single Gradle plugin into a core plugin and an Android-specific plugin
- Add a
requireLicense
option with strict-mode handling inAboutLibrariesTask
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
settings.gradle.kts | Upgrade MikePenz version-catalog plugin from 0.3.9 to 0.6.0 |
plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/BaseAboutLibrariesTask.kt | Add requireLicense input property |
plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesTask.kt | Implement requireLicense logic and restructure strict-mode flows |
plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesPluginAndroidExtension.kt | Generalize Android task registration via a callback parameter |
plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesPluginAndroid.kt | Add new Android-specific Gradle plugin |
plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesPlugin.kt | Remove old Android flag check and always call core configureAndroidTasks |
plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesExtension.kt | Deprecate old AndroidConfig, add requireLicense default convention |
plugin-build/plugin/build.gradle.kts | Register new aboutlibsAndroidPlugin with metadata |
gradle/libs.versions.toml | Bump serialization, navigation, and modelBuilder versions |
gradle.properties | Add Kotlin 2.2 and disable compatPatrouille |
app/build.gradle.kts | Apply new Android plugin and remove deprecated flag |
app-test/build.gradle.kts | Remove deprecated Android flag |
README.md | Note split plugin release |
MIGRATION.md | Document plugin split under v13.0.0 |
Comments suppressed due to low confidence (3)
plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesTask.kt:129
- Introduce unit tests covering the new
requireLicense
behavior under bothWARN
andFAIL
strict modes, ensuring libraries with missing licenses are handled correctly.
val librariesWithoutLicense = if (requireLicense.get()) libraries.filter { it.licenses.isEmpty() } else emptyList()
README.md:44
- Update the v13.0.0 link to point to the correct
v13.0.0
tag (instead of the old12.2.4
), e.g./tree/v13.0.0
.
- Split Gradle Plugin | [v13.0.0](https://github.com/mikepenz/AboutLibraries/tree/12.2.4)
MIGRATION.md:3
- Add a note about the new
requireLicense
property and its default behavior in strict modes so users know how to adopt it during migration.
#### v13.0.0
@@ -37,6 +37,9 @@ abstract class BaseAboutLibrariesTask : DefaultTask() { | |||
@get:Input | |||
abstract val variant: Property<String?> | |||
|
|||
@Input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use @get:Input
instead of @Input
to properly annotate the Kotlin property for Gradle’s incremental build inputs.
Copilot uses AI. Check for mistakes.
- Compose 1.8.3 / Compose Multiplatform 1.8.2 - Serialization 1.9.0
06f2a3b
to
f50935f
Compare
# androidx | ||
activity = "1.10.1" | ||
cardview = "1.0.0" | ||
constraintLayout = "2.2.1" | ||
core = "1.16.0" | ||
lifecycle = { require = "2.8.7" } | ||
navigation = "2.8.9" | ||
navigation = "2.9.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newer version of androidx.navigation.safeargs than 2.9.0 is available: 2.9.1 |
# androidx | ||
activity = "1.10.1" | ||
cardview = "1.0.0" | ||
constraintLayout = "2.2.1" | ||
core = "1.16.0" | ||
lifecycle = { require = "2.8.7" } | ||
navigation = "2.8.9" | ||
navigation = "2.9.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newer version of androidx.navigation:navigation-fragment than 2.9.0 is available: 2.9.1 |
# androidx | ||
activity = "1.10.1" | ||
cardview = "1.0.0" | ||
constraintLayout = "2.2.1" | ||
core = "1.16.0" | ||
lifecycle = { require = "2.8.7" } | ||
navigation = "2.8.9" | ||
navigation = "2.9.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newer version of androidx.navigation:navigation-safe-args-gradle-plugin than 2.9.0 is available: 2.9.1 |