Add option for full-spoke radial trajectory#116
Open
fyrdahl wants to merge 1 commit intomikgroup:mainfrom
Open
Add option for full-spoke radial trajectory#116fyrdahl wants to merge 1 commit intomikgroup:mainfrom
fyrdahl wants to merge 1 commit intomikgroup:mainfrom
Conversation
|
Any ideas why the checks failed? Not much info available from travis ci without a login? |
Author
|
It's a bunch of failed flake8 tests, most of which seem unrelated to this PR. The failed test which I believe is related is an E501 line too long. Since most errors are unrelated to this PR, fixing the PR itself probably won't solve the failed checks. I think PEP8 should be abided by when possible but breaking up the argument list into multiple lines is a departure from the coding style in the rest of the code base. This will probably become a bigger problem when someone gets around to fixing the deprecated datatypes, which will add 2-3 chars to every line that specifies a dtype. |
Collaborator
|
Hi, sorry -- I updated the tooling. Can you please run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the radial trajectory code defaulted to half-spoke (center-out) with no option to use full spokes, so I added that option. The default behavior doesn't change, but the new option is a closer match to what is described in the referenced papers.
The change to
betain the full-spoke 3D-radial case is not strictly necessary, but the change reflects how it's described in the original paper.I also changed the deprecated
np.floattonp.float32, as I understand you prefer explicit size instead of the built-in types.