Add colormap to plot.ImagePlot #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A colormap can now be set in constructing the ImagePlot class, and when a colormap is set, a colorbar will be automatically added to the right of the image.
frankong
reviewed
Oct 29, 2019
sigpy/plot.py
Outdated
| @@ -100,6 +101,7 @@ def __init__( | |||
| self.title = title | |||
| self.interpolation = interpolation | |||
| self.mode = mode | |||
| self.colormap=colormap | |||
There was a problem hiding this comment.
Hi @Zhitao-Li , sorry for the late reply. Can you add spaces around the equal sign? This is to conform with PEP8
This display range will only affect magnitude images, include real and imaginary part of a complex image, but not phase images, since phase image has a very different display range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A colormap can now be set in constructing the ImagePlot class, and when
a colormap is set, a colorbar will be automatically added to the right
of the image.