fix: support custom repositories with EntitySchema/defineEntity#235
Merged
Conversation
When using `forFeature()` with entities defined via `EntitySchema` or `defineEntity`, custom repositories were not being registered as providers. This was because the metadata lookup only checked for class-based entities. Now the code properly handles `EntitySchema` instances by accessing their metadata directly via `entity.meta`. Closes mikro-orm/mikro-orm#6701
B4nan
force-pushed
the
entity-schema-repositories
branch
from
db50317 to
4044caa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
forFeature()with entities defined viaEntitySchemaordefineEntity, custom repositories were not being registered as providers. This was because the metadata lookup only checked for class-based entities.Now the code properly handles
EntitySchemainstances by accessing their metadata directly viaentity.meta.Closes mikro-orm/mikro-orm#6701