Merged
Conversation
rousseab
reviewed
May 26, 2025
rousseab
reviewed
May 26, 2025
rousseab
reviewed
May 26, 2025
rousseab
reviewed
May 26, 2025
rousseab
reviewed
May 26, 2025
rousseab
reviewed
May 26, 2025
rousseab
reviewed
May 26, 2025
rousseab
reviewed
May 26, 2025
rousseab
reviewed
May 26, 2025
src/diffusion_for_multi_scale_molecular_dynamics/active_learning_loop/excisor/base_excisor.py
Outdated
Show resolved
Hide resolved
rousseab
reviewed
May 27, 2025
...on_for_multi_scale_molecular_dynamics/active_learning_loop/sample_maker/base_sample_maker.py
Outdated
Show resolved
Hide resolved
rousseab
reviewed
May 27, 2025
...on_for_multi_scale_molecular_dynamics/active_learning_loop/sample_maker/base_sample_maker.py
Outdated
Show resolved
Hide resolved
rousseab
reviewed
May 27, 2025
...on_for_multi_scale_molecular_dynamics/active_learning_loop/sample_maker/base_sample_maker.py
Outdated
Show resolved
Hide resolved
rousseab
reviewed
May 27, 2025
...on_for_multi_scale_molecular_dynamics/active_learning_loop/sample_maker/base_sample_maker.py
Outdated
Show resolved
Hide resolved
rousseab
reviewed
May 27, 2025
...on_for_multi_scale_molecular_dynamics/active_learning_loop/sample_maker/base_sample_maker.py
Show resolved
Hide resolved
rousseab
reviewed
May 27, 2025
...on_for_multi_scale_molecular_dynamics/active_learning_loop/sample_maker/base_sample_maker.py
Outdated
Show resolved
Hide resolved
rousseab
reviewed
May 27, 2025
...on_for_multi_scale_molecular_dynamics/active_learning_loop/sample_maker/base_sample_maker.py
Show resolved
Hide resolved
rousseab
reviewed
May 27, 2025
...on_for_multi_scale_molecular_dynamics/active_learning_loop/sample_maker/base_sample_maker.py
Show resolved
Hide resolved
rousseab
reviewed
May 27, 2025
...cale_molecular_dynamics/active_learning_loop/sample_maker/excise_and_repaint_sample_maker.py
Outdated
Show resolved
Hide resolved
rousseab
requested changes
May 27, 2025
Collaborator
rousseab
left a comment
rousseab
left a comment
There was a problem hiding this comment.
Looks great!
I make a few suggestions about typos and such.
added 2 commits
May 27, 2025 15:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I introduce the "sample maker" class, which is a generator but with a different name to avoid overloading terms.
Given an input structure (AXL), the sample maker generates new candidates. The BaseExciseSampleMaker uses an excisor under the hood to find the initial problematic substructure. The ExciseAndRepaintSampleMaker inherits from this and uses an axl score network for repainting the structure.
I added a tutorial, which is probably the best entry point to get an overview of the method.
Note that I defined a filter method, which does nothing for now. We will be able to override them later if we want to add heuristics (such as no two atoms on top of each other)