Skip to content

Optimize flare better #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 13, 2025
Merged

Optimize flare better #146

merged 14 commits into from
Jun 13, 2025

Conversation

rousseab
Copy link
Collaborator

In this PR:

  • I fix the problem in the "sample_maker" configuration class. It turns out you have to TYPE everything the same way in a child class or else you get problems.
  • I fix the overlogging problem, where loggers would step on each other's toes
  • I revamp how the hyperparameters of a FLARE model are optimized, including not optimizing them at all.
  • I change some knick-knack here and there.

@rousseab rousseab requested a review from sblackburn86 June 12, 2025 12:43
sblackburn86
sblackburn86 approved these changes Jun 13, 2025
View reviewed changes
Copy link
Collaborator

@sblackburn86 sblackburn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sblackburn86 sblackburn86 merged commit 754dfde into main Jun 13, 2025
1 check passed
@sblackburn86 sblackburn86 deleted the optimize_flare_better branch June 13, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sblackburn86 sblackburn86 sblackburn86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rousseab @sblackburn86