Skip to content

Difface #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 6, 2024
Merged

Difface #53

merged 13 commits into from
Jun 6, 2024

Conversation

rousseab
Copy link
Collaborator

@rousseab rousseab commented Jun 4, 2024

A reworking of the 'Diffusion MACE' architecture.

The main insight is that the node attributes should probably NOT be the values of sigma; sigma is often close to zero, so a linear layer without bias will just send everything to zero.

Here we create "augmented" node attributes by mixing the attributes coming from the one-hot encoded atom types and a MLP (with biases) applied to sigma.

This new architecture can overfit a single example of the score with fixed values of sigma:
From experiments/diffusion_mace_harmonic_data/overfit_diffusion_mace.py
(Different experiments have sigma = 0.001, 0.1, 0.5, and some fiddling with number of MLP layers and channels)
Screenshot 2024-06-04 at 1 57 06 PM

This requires much fewer parameters than the previous monstrosities because the tensorproduct is only on 0e x 0e channels.

Finding the right parameters is very 'fiddly'. There's much exploration to be done to see if this can learn what we want.

@rousseab rousseab requested a review from sblackburn86 June 4, 2024 18:16
@rousseab rousseab merged commit 2b9df8d into main Jun 6, 2024
1 check passed
@rousseab rousseab deleted the difface branch June 6, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants