Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct syntax for configure block in README.md #1105

Closed
wants to merge 2 commits into from

Conversation

pcothenet
Copy link

@pcothenet pcothenet commented Feb 27, 2024

The syntax for the configure block in the doc was incorrect.

As far as I can tell WickedPdf doesn't support a configure block.

@unixmonkey
Copy link
Collaborator

The syntax was changed pretty recently in #1090 but not packaged up into a new gem version yet, mostly because I haven't written up all the changes in the CHANGELOG yet.

Thanks for reminding me this needs done. I'll get a new release out very soon.

@pcothenet
Copy link
Author

@unixmonkey that makes sense! Feel free to close this once done.

@unixmonkey
Copy link
Collaborator

I've just published version 2.8.0 of the Wicked PDF gem, that includes the new configure block syntax.

Thank you for caring enough to contribute!

Please let me know if you have any issues.

@unixmonkey unixmonkey closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants