Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for frozen string literal to prepare for ruby 3.4 #1118

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix for frozen string literal to prepare for ruby 3.4 #1118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/wicked_pdf/tempfile.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ def write_in_chunks(input_string)
def read_in_chunks
rewind
binmode
output_string = ''
output_string << read(chunk_size) until eof?
output_string
chunks = []
chunks << read(chunk_size) until eof?
chunks.join
rescue Errno::EINVAL => e
raise e, file_too_large_message
end
Expand Down
Loading