Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ostruct as dependency for Ruby 3.5.0 #1131

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

garyhtou
Copy link
Contributor

Starting from Ruby 3.5.0, ostruct will no longer be included as a default gem. This means that it must be added to the gemspec.

Here is the deprecation message:

/Users/garyhtou/.rbenv/versions/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75: warning: /Users/garyhtou/.rbenv/versions/3.3.5/lib/ruby/3.3.0/ostruct.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
Also please contact the author of wicked_pdf-2.8.1 to request adding ostruct into its gemspec.

Closes #1129

Starting from Ruby 3.5.0, `ostruct` will no longer be included as a default gem. This means that it must be added to the gemspec.

Here is the deprecation message:
```
/Users/garyhtou/.rbenv/versions/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75: warning: /Users/garyhtou/.rbenv/versions/3.3.5/lib/ruby/3.3.0/ostruct.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
Also please contact the author of wicked_pdf-2.8.1 to request adding ostruct into its gemspec.
```
Copy link
Collaborator

@unixmonkey unixmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@unixmonkey unixmonkey merged commit 8657978 into mileszs:master Oct 26, 2024
12 checks passed
@unixmonkey
Copy link
Collaborator

This is now in version 2.8.2. Thank you for your help ❤️

@garyhtou garyhtou deleted the garyhtou/ostruct branch October 27, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ostruct to gemspec
2 participants