Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created image search demo #1373

Closed
wants to merge 4 commits into from
Closed

created image search demo #1373

wants to merge 4 commits into from

Conversation

reina-w
Copy link

@reina-w reina-w commented Jul 9, 2024

No description provided.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: reina-w

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link

Welcome @reina-w! It looks like this is your first PR to milvus-io/bootcamp 🎉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to pics/

logger = logging.getLogger(__name__)
logger.info("Logging is configured and working.")

root = "./train"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line as unused root

enable_dynamic_field=True,
metric_type="COSINE",
)
insert_embeddings(client)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

db_exists_check should not include the step of inserting embeddings.

extractor = load_model("resnet34")


def insert_embeddings(client):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this function to insert.py & import milvus utils in insert.py.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insert.py should include steps of preparing data, generating & inserting embeddings.

- Search for similar images using Milvus for efficient similarity search.
- Display search results along with similarity scores.

## Demo Structure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Structure

```

### Dataset Preparation
We need to load the dataset and unextract it for further processing.
Copy link
Contributor

@jaelgu jaelgu Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a short introduction for the example data & its link. btw, typo: "unextract"

@reina-w reina-w closed this Jul 11, 2024
@reina-w reina-w deleted the demo-app branch July 11, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants