Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Multimodal RAG notebook #1398

Closed
wants to merge 1 commit into from

Conversation

reina-w
Copy link

@reina-w reina-w commented Jul 29, 2024

Added multimodal rag search notebook corresponding to the quickstart streamlit application

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: reina-w

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,884 @@
{
Copy link
Contributor

@jaelgu jaelgu Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect link & method to add colab.


Reply via ReviewNB

@@ -0,0 +1,884 @@
{
Copy link
Contributor

@jaelgu jaelgu Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #1.    !pip install --upgrade pymilvus Pillow numpy opencv-python datasets openai

remove numpy since it has been already required by pymilvus


Reply via ReviewNB

@@ -0,0 +1,884 @@
{
Copy link
Contributor

@jaelgu jaelgu Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to setup env in Jupyter notebook.


Reply via ReviewNB

@@ -0,0 +1,884 @@
{
Copy link
Contributor

@jaelgu jaelgu Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto


Reply via ReviewNB

@@ -0,0 +1,884 @@
{
Copy link
Contributor

@jaelgu jaelgu Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a good option to git clone the whole project or use cd command in jupyter notebook. Remove this section and install necessary dependencies in the "Install Dependencies" section.


Reply via ReviewNB

@@ -0,0 +1,884 @@
{
Copy link
Contributor

@jaelgu jaelgu Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add command.


Reply via ReviewNB

@@ -0,0 +1,884 @@
{
Copy link
Contributor

@jaelgu jaelgu Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add description here


Reply via ReviewNB

@@ -0,0 +1,884 @@
{
Copy link
Contributor

@jaelgu jaelgu Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data should be prepared in advance. Split the section into 2 sections: "Prepare Data" and "Create Collection".


Reply via ReviewNB

@@ -0,0 +1,884 @@
{
Copy link
Contributor

@jaelgu jaelgu Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add short descriptions for each function. Only keep necessary functions. Remove those just required for online demo (eg. cache function).


Reply via ReviewNB

@@ -0,0 +1,884 @@
{
Copy link
Contributor

@jaelgu jaelgu Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect format to add image.


Reply via ReviewNB

@jaelgu jaelgu closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants