Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llama-agents] Add an example w/ llama-agents and Milvus #1401

Merged
merged 8 commits into from
Aug 16, 2024

Conversation

stephen37
Copy link
Contributor

@stephen37 stephen37 commented Jul 31, 2024

This PR adds an example on how to use llama-agents with Milvus. It showcases the ability to use an agent to make decision based on the user's query.
In this example, we show that the agent can pick which Milvus collection to use.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,569 @@
{
Copy link
Collaborator

@codingjaguar codingjaguar Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo contains the core components of Milvus Lite.

-- this is not related to this notebook.


Reply via ReviewNB

@@ -0,0 +1,569 @@
{
Copy link
Collaborator

@codingjaguar codingjaguar Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, the logo is a bit too large.


Reply via ReviewNB

@@ -0,0 +1,569 @@
{
Copy link
Collaborator

@codingjaguar codingjaguar Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to previous comment, these code blocks are a bit too dry. there shall be some lubricates like illustration "in the next section we need to blabla"


Reply via ReviewNB

@@ -0,0 +1,767 @@
{
Copy link
Collaborator

@codingjaguar codingjaguar Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, the logo seems too big. Should be able to scale it in notebook?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It kinda does, it scales with the size of your screen basically. as far as I know Markdown doesn't really support scaling, I could take a smaller image though I guess.

@@ -0,0 +1,767 @@
{
Copy link
Collaborator

@codingjaguar codingjaguar Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the visual is very intuitive. good point.


Reply via ReviewNB

@@ -0,0 +1,767 @@
{
Copy link
Collaborator

@codingjaguar codingjaguar Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth explaining what these few lines about load dotenv is doing.


Reply via ReviewNB

@stephen37
Copy link
Contributor Author

@codingjaguar Ready for review again, thanks for the comments btw, it made the Notebook so much better! 💙

@stephen37
Copy link
Contributor Author

@codingjaguar I removed ReActAgent, it was a bit of a pain, I also addressed your comments, let me know what you think now 🙌

@codingjaguar
Copy link
Collaborator

/lgtm

@sre-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot removed the lgtm label Aug 16, 2024
@codingjaguar
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: codingjaguar, stephen37

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codingjaguar codingjaguar merged commit 4fcb05b into milvus-io:master Aug 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants