-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[llama-agents] Add an example w/ llama-agents and Milvus #1401
[llama-agents] Add an example w/ llama-agents and Milvus #1401
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -0,0 +1,569 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo contains the core components of Milvus Lite.
-- this is not related to this notebook.
Reply via ReviewNB
@@ -0,0 +1,569 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,569 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar to previous comment, these code blocks are a bit too dry. there shall be some lubricates like illustration "in the next section we need to blabla"
Reply via ReviewNB
@@ -0,0 +1,767 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It kinda does, it scales with the size of your screen basically. as far as I know Markdown doesn't really support scaling, I could take a smaller image though I guess.
@@ -0,0 +1,767 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,767 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codingjaguar Ready for review again, thanks for the comments btw, it made the Notebook so much better! 💙 |
@codingjaguar I removed ReActAgent, it was a bit of a pain, I also addressed your comments, let me know what you think now 🙌 |
/lgtm |
New changes are detected. LGTM label has been removed. |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: codingjaguar, stephen37 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds an example on how to use llama-agents with Milvus. It showcases the ability to use an agent to make decision based on the user's query.
In this example, we show that the agent can pick which Milvus collection to use.