This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
Remove omp process in diskann index #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cqy123456 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cqy123456
changed the title
|
@cqy123456 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
cqy123456
force-pushed
the
remove-diskann-omp
branch
from
241ec61 to
0cd8b37
Compare
liliu-z
reviewed
Mar 22, 2023
| // query at a time. More threads will result in higher aggregate query throughput, but will also use more IOs/second | ||
| // across the system, which may lead to higher per-query latency. So find the balance depending on the maximum | ||
| // number of IOPs supported by the SSD. | ||
| CFG_INT num_threads; |
There was a problem hiding this comment.
Will existed code crash due to num_threads turning to invalid?
There was a problem hiding this comment.
I put this key into ext_legal_json_keys, and it still legal.
| @@ -493,7 +504,6 @@ int generate_pq_data_from_pivots(const std::string data_file, | |||
| LOG_KNOWHERE_DEBUG_ << "Processing points [" << start_id << ", " << end_id | |||
| << ").."; | |||
|
|
|||
| #pragma omp parallel for firstprivate(block_data_tmp) schedule(static, 8192) | |||
There was a problem hiding this comment.
Is it OK here to not replace omp with any pool?
cqy123456
force-pushed
the
remove-diskann-omp
branch
from
0cd8b37 to
244aaa7
Compare
cqy123456
force-pushed
the
remove-diskann-omp
branch
from
244aaa7 to
306d9c7
Compare
cqy123456
force-pushed
the
remove-diskann-omp
branch
from
306d9c7 to
9e63eee
Compare
Signed-off-by: cqy123456 <[email protected]>
cqy123456
force-pushed
the
remove-diskann-omp
branch
from
9e63eee to
84390fc
Compare
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #782
Comparison between omp and thread pool on building diskann as follow：
dataset: sift1m128d
threads number: 12