This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
Fix: memory overflow for test code #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
|
@matrixji Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
|
/kind improvement |
Signed-off-by: Ji Bin <[email protected]>
Presburger
approved these changes
Jul 21, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matrixji, Presburger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Presburger
reviewed
Jul 21, 2023
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modify some test param, but it may crash due to the temp vector
vin GetKNNRecall is not enough.