-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MilvusInterceptor #269
base: master
Are you sure you want to change the base?
Conversation
brcarry
commented
Jan 3, 2025
- Add MilvusInterceptor
- Save gRPC request headers in MilvusConnection
- Support login using uri and token
- Add ListIndexes, ListCollections, ListPartitions, Upsert, Get, ListUsers, DescribeUser, CreateUser, DropUser and UpdatePassword; rename GetCollectionStats, GetPartitionStats
- Update milvus proto version to v2.5.0
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: brcarry The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @brcarry! It looks like this is your first PR to milvus-io/milvus-sdk-cpp 🎉 |
I just submit a pr to fix the ci failure: #272 |
@brcarry Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
any reason of adding this interceptor? |
For authentication and configuration. |
Signed-off-by: Ruichen Bao <[email protected]>
Signed-off-by: Ruichen Bao <[email protected]>
Signed-off-by: Ruichen Bao <[email protected]>
…ts, GetPartitionStats Signed-off-by: Ruichen Bao <[email protected]>
Signed-off-by: Ruichen Bao <[email protected]>
Signed-off-by: Ruichen Bao <[email protected]>
Signed-off-by: Ruichen Bao <[email protected]>
Signed-off-by: Ruichen Bao <[email protected]>
- Add MilvusInterceptor - Save gRPC request headers in MilvusConnection Signed-off-by: Ruichen Bao <[email protected]>
Signed-off-by: Ruichen Bao <[email protected]>
Signed-off-by: Ruichen Bao <[email protected]>
…e and ListRoles Signed-off-by: Ruichen Bao <[email protected]>
…ilege Signed-off-by: Ruichen Bao <[email protected]>
Signed-off-by: Ruichen Bao <[email protected]>
…abase, AlterDatabaseProperties and DropDatabaseProperties Signed-off-by: Ruichen Bao <[email protected]>
…AlterCollectionField Signed-off-by: Ruichen Bao <[email protected]>
…s, AddPrivilegesToGroup, RemovePrivilegesFromGroup, GrantPrivilegeV2 and RevokePrivilegeV2 Signed-off-by: Ruichen Bao <[email protected]>
…eResourceGroup, ListResourceGroups and UpdateResourceGroup Signed-off-by: Ruichen Bao <[email protected]>
Signed-off-by: Ruichen Bao <[email protected]>
Signed-off-by: Ruichen Bao <[email protected]>
…tJobProgress Signed-off-by: Ruichen Bao <[email protected]>
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (3.44%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
===========================================
- Coverage 97.33% 59.17% -38.17%
===========================================
Files 34 50 +16
Lines 2628 4426 +1798
===========================================
+ Hits 2558 2619 +61
- Misses 70 1807 +1737
|