Skip to content

Commit

Permalink
Switch to using the public Milvus testcontainer
Browse files Browse the repository at this point in the history
Continues #57
  • Loading branch information
roji committed Mar 20, 2024
1 parent 7d18143 commit 2ccee69
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 128 deletions.
2 changes: 1 addition & 1 deletion Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<PackageVersion Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Configuration.Json" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
<PackageVersion Include="Testcontainers" Version="3.7.0" />
<PackageVersion Include="Testcontainers.Milvus" Version="3.8.0" />
<PackageVersion Include="GitHubActionsTestLogger" Version="2.3.3" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion Milvus.Client.Tests/Milvus.Client.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
</PackageReference>
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" />
<PackageReference Include="Testcontainers" />
<PackageReference Include="Testcontainers.Milvus" />
<PackageReference Include="GitHubActionsTestLogger" />
</ItemGroup>

Expand Down
6 changes: 2 additions & 4 deletions Milvus.Client.Tests/MilvusFixture.cs
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
using System.Globalization;
using Microsoft.Extensions.Configuration;
using Milvus.Client.Tests.TestContainer;
using Testcontainers.Milvus;
using Xunit;

namespace Milvus.Client.Tests;

[CollectionDefinition("Milvus")]
public sealed class QdrantCollection : ICollectionFixture<MilvusFixture>;
public sealed class MilvusTestCollection : ICollectionFixture<MilvusFixture>;

public sealed class MilvusFixture : IAsyncLifetime
{
Expand Down
61 changes: 0 additions & 61 deletions Milvus.Client.Tests/TestContainer/MilvusBuilder.cs

This file was deleted.

54 changes: 0 additions & 54 deletions Milvus.Client.Tests/TestContainer/MilvusConfiguration.cs

This file was deleted.

7 changes: 0 additions & 7 deletions Milvus.Client.Tests/TestContainer/MilvusContainer.cs

This file was deleted.

0 comments on commit 2ccee69

Please sign in to comment.