Skip to content
This repository was archived by the owner on Mar 21, 2025. It is now read-only.

Conversation

@unfode
Copy link
Contributor

@unfode unfode commented Oct 17, 2023

Implement SearchByPks in Go SDK corresponding to the newly added SearchByPks endpoint in Milvus (milvus-io/milvus#25882)

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: unfode
To complete the pull request process, please assign yah01 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yah01 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link

Welcome @unfode! It looks like this is your first PR to milvus-io/milvus-sdk-go 🎉

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 17, 2023
@unfode unfode force-pushed the searchByPks branch 2 times, most recently from da221f8 to 6bae0f3 Compare October 18, 2023 02:36
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: Patch coverage is 48.88889% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 81.90%. Comparing base (647cbab) to head (13fce3c).
Report is 36 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
- Coverage   82.85%   81.90%   -0.96%     
==========================================
  Files          40       40              
  Lines        3640     3681      +41     
==========================================
- Hits         3016     3015       -1     
- Misses        512      555      +43     
+ Partials      112      111       -1     
Files Coverage Δ
client/client.go 28.94% <ø> (ø)
client/data.go 61.35% <48.88%> (-7.65%) ⬇️

@mergify mergify bot added the ci-passed auto merge needed label label Oct 18, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Oct 19, 2023
@yah01
Copy link
Member

yah01 commented Oct 19, 2023

/cc @congqixia

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ci-passed auto merge needed label lgtm look good to me size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants