feat: add missing proto fields to RunAnalyzer API#507
Merged
shanghaikid merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shanghaikid The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…n_name, field_name, analyzer_names) Support running analyzer by specifying collection field or analyzer names instead of inline analyzer_params. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: ryjiang <[email protected]>
shanghaikid
force-pushed
the
feat/run-analyzer-full-proto-support
branch
from
c7b4d57 to
abee67f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 54 54
Lines 3925 3928 +3
Branches 1034 1037 +3
=======================================
+ Hits 3820 3823 +3
Misses 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
db_name,collection_name,field_name,analyzer_namesfields toRunAnalyzerRequest, aligning with the proto definitionanalyzer_params,with_detail,with_hashoptional, since users can specify analyzer via collection field or analyzer names insteadcollection_name+field_nameanddb_nameusageTest plan
yarn buildpassesNODE_ENV=dev npx jest test/grpc/FullTextSearch.spec.ts)run analyzer with collection_name and field_name should successrun analyzer with db_name should success🤖 Generated with Claude Code