Skip to content

enhance: unlink mmap file when chunk and index are destructed #43524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jul 23, 2025

issue: #41636

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 23, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 23, 2025
Copy link
Contributor

mergify bot commented Jul 23, 2025

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jul 23, 2025

@sunby cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@czs007 czs007 added this to the 2.6.0 milestone Jul 24, 2025
Copy link
Contributor

mergify bot commented Jul 24, 2025

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jul 24, 2025

@sunby cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jul 24, 2025

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Jul 25, 2025

rerun ut

@sunby
Copy link
Contributor Author

sunby commented Jul 25, 2025

/run-cpu-e2e

@sunby
Copy link
Contributor Author

sunby commented Jul 25, 2025

rerun go-sdk

@sunby
Copy link
Contributor Author

sunby commented Jul 25, 2025

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Jul 25, 2025

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jul 25, 2025

@sunby cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jul 25, 2025

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

codecov bot commented Jul 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.95%. Comparing base (369a811) to head (fb69e81).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #43524      +/-   ##
==========================================
- Coverage   78.96%   78.95%   -0.01%     
==========================================
  Files        1567     1567              
  Lines      224630   224729      +99     
==========================================
+ Hits       177374   177440      +66     
- Misses      40831    40858      +27     
- Partials     6425     6431       +6     
Components Coverage Δ
Client 79.47% <ø> (ø)
Core 74.06% <100.00%> (+0.04%) ⬆️
Go 79.90% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/common/Chunk.h 89.65% <100.00%> (+1.01%) ⬆️
internal/core/src/common/ChunkWriter.cpp 98.29% <100.00%> (+0.09%) ⬆️
internal/core/src/common/ChunkWriter.h 93.06% <100.00%> (+0.43%) ⬆️
internal/core/src/common/File.h 82.75% <100.00%> (+4.49%) ⬆️
internal/core/src/index/BitmapIndex.cpp 83.68% <100.00%> (ø)
internal/core/src/index/Index.h 60.00% <ø> (ø)
internal/core/src/index/StringIndexMarisa.cpp 75.00% <100.00%> (ø)
internal/core/src/index/VectorMemIndex.cpp 64.00% <100.00%> (ø)
...rc/segcore/storagev1translator/ChunkTranslator.cpp 91.48% <ø> (-0.18%) ⬇️
...gcore/storagev2translator/GroupChunkTranslator.cpp 98.30% <ø> (-0.03%) ⬇️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants