Skip to content

enhance: update knowhere version #43528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

foxspy
Copy link
Contributor

@foxspy foxspy commented Jul 23, 2025

issue: #42937

Signed-off-by: xianliang.li <[email protected]>
@sre-ci-robot sre-ci-robot added area/compilation size/XS Denotes a PR that changes 0-9 lines. labels Jul 23, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 23, 2025
Copy link
Collaborator

@czs007 czs007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jul 23, 2025

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.86%. Comparing base (abb3aea) to head (20e2689).
Report is 9 commits behind head on master.

❌ Your project check has failed because the head coverage (73.86%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #43528   +/-   ##
=======================================
  Coverage   73.86%   73.86%           
=======================================
  Files         345      345           
  Lines       32953    32953           
=======================================
  Hits        24342    24342           
  Misses       8611     8611           
Components Coverage Δ
Client ∅ <ø> (∅)
Core 73.86% <ø> (ø)
Go ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@foxspy
Copy link
Contributor Author

foxspy commented Jul 24, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jul 24, 2025

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Jul 24, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jul 24, 2025

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Jul 25, 2025

rerun go-sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants