Skip to content

enhance: [StorageV2] add close state validation for storage readers and writers #43550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shaoting-huang
Copy link
Contributor

related: #39173

bump milvus-storage version, include:

key changes:

  • Add closed_ flag to ParquetFileWriter to prevent operations on closed writers
  • Add closed_ flag to PackedRecordBatchWriter to prevent operations on closed writers
  • Add file reader tracking fields to PackedRecordBatchReader (file_reader_to_path_index_, original_paths_, read_count_)
  • Implement proper close state checking in writer implementations
  • Prevent duplicate close operations and ensure proper cleanup

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shaoting-huang
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. area/compilation labels Jul 24, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 24, 2025
Copy link
Contributor

mergify bot commented Jul 24, 2025

@shaoting-huang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.86%. Comparing base (804a769) to head (fb68ea8).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #43550       +/-   ##
===========================================
- Coverage   79.82%   73.86%    -5.96%     
===========================================
  Files        1221      345      -876     
  Lines      191502    32956   -158546     
===========================================
- Hits       152858    24343   -128515     
+ Misses      32231     8613    -23618     
+ Partials     6413        0     -6413     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 73.86% <ø> (∅)
Go ∅ <ø> (∅)

see 1566 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shaoting-huang
Copy link
Contributor Author

rerun ut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants