Skip to content

fix: apply load config changes failed after restart #43555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.5
Choose a base branch
from

Conversation

weiliu1031
Copy link
Contributor

issue: #43107
pr: #43554

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 24, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 24, 2025
@sre-ci-robot sre-ci-robot added do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager labels Jul 24, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[FAILED] PR #43554 not merged

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 89.36170% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (2.5@4204c04). Learn more about missing BASE report.
Report is 2 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/querycoordv2/services.go 76.19% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.5   #43555   +/-   ##
======================================
  Coverage       ?   80.61%           
======================================
  Files          ?     1431           
  Lines          ?   207222           
  Branches       ?        0           
======================================
  Hits           ?   167054           
  Misses         ?    34296           
  Partials       ?     5872           
Components Coverage Δ
Client 79.27% <ø> (?)
Core 70.61% <ø> (?)
Go 82.58% <89.36%> (?)
Files with missing lines Coverage Δ
internal/querycoordv2/server.go 79.42% <100.00%> (ø)
internal/querycoordv2/services.go 85.32% <76.19%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Jul 24, 2025
Signed-off-by: Wei Liu <[email protected]>
@mergify mergify bot removed the ci-passed label Jul 25, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[FAILED] PR #43554 not merged

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

Copy link
Contributor

mergify bot commented Jul 25, 2025

@weiliu1031 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants