fix: use tantivy version to make json index compatible with milvus 2.5 #43563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sunby <[email protected]>
mergify
bot
added
dco-passed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43563 +/- ##
=======================================
Coverage 78.96% 78.96%
=======================================
Files 1567 1567
Lines 224630 224644 +14
=======================================
+ Hits 177374 177399 +25
+ Misses 40831 40821 -10
+ Partials 6425 6424 -1
🚀 New features to boost your workflow:
|
SpadeA-Tang
reviewed
Jul 25, 2025
| field_name.c_str(), | ||
| this->d_type_, | ||
| this->path_.c_str(), | ||
| TANTIVY_INDEX_LATEST_VERSION /* json index is not supported in old version */); |
There was a problem hiding this comment.
Is json index supported in 2.5?
There was a problem hiding this comment.
Is json index supported in 2.5?
actually yes
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SpadeA-Tang, sunby, zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #43562