Skip to content

fix: pulsar use more memory for queue #43565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jul 25, 2025

issue: #43564

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 25, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 25, 2025
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.95%. Comparing base (070aabd) to head (1214a2d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/streaming/walimpls/impls/pulsar/wal.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #43565      +/-   ##
==========================================
- Coverage   78.95%   78.95%   -0.01%     
==========================================
  Files        1567     1567              
  Lines      224715   224718       +3     
==========================================
- Hits       177419   177416       -3     
- Misses      40866    40874       +8     
+ Partials     6430     6428       -2     
Components Coverage Δ
Client 79.47% <ø> (ø)
Core 74.03% <ø> (+<0.01%) ⬆️
Go 79.89% <50.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
...ming/walimpls/impls/pulsar/backlog_clear_helper.go 68.60% <100.00%> (+0.36%) ⬆️
pkg/streaming/walimpls/impls/pulsar/wal.go 66.66% <0.00%> (-0.57%) ⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chyezh chyezh force-pushed the fix_pulsar_much_memory branch from 855ba9d to ba94b7e Compare July 25, 2025 09:35
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jul 25, 2025
@chyezh chyezh force-pushed the fix_pulsar_much_memory branch from ba94b7e to 1214a2d Compare July 25, 2025 12:33
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jul 25, 2025
Copy link
Contributor

mergify bot commented Jul 25, 2025

@chyezh cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jul 25, 2025

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jul 25, 2025

rerun cpp-unit-test

@chyezh
Copy link
Contributor Author

chyezh commented Jul 25, 2025

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jul 25, 2025

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jul 26, 2025

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants