Skip to content

fix: dirty cp metrics after drop #43567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: dirty cp metrics after drop #43567

wants to merge 1 commit into from
+0 −5

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jul 25, 2025

issue: #42688

  • The channel cp is dropped by garbage collector
  • The channel is dropped and the cp is marked as math.Uint64
  • If we drop it here, the update channel checkpoints will write the dirty cp back.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 25, 2025
@sre-ci-robot sre-ci-robot requested review from congqixia and sunby July 25, 2025 09:18
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 25, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 25, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jul 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.01%. Comparing base (0b860b4) to head (386dac8).
⚠️ Report is 4 commits behind head on master.

❌ Your project check has failed because the head coverage (74.01%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #43567       +/-   ##
===========================================
- Coverage   78.95%   74.01%    -4.95%     
===========================================
  Files        1567      346     -1221     
  Lines      224716    33091   -191625     
===========================================
- Hits       177431    24493   -152938     
+ Misses      40865     8598    -32267     
+ Partials     6420        0     -6420
Components Coverage Δ
Client ∅ <ø> (∅)
Core 74.01% <ø> (+0.01%) ⬆️
Go ∅ <ø> (∅)
see 1222 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chyezh
Copy link
Contributor Author

chyezh commented Jul 25, 2025

rerun go-sdk

@chyezh
Copy link
Contributor Author

chyezh commented Jul 25, 2025

rerun ut

4 similar comments
@chyezh
Copy link
Contributor Author

chyezh commented Jul 25, 2025

rerun ut

@chyezh
Copy link
Contributor Author

chyezh commented Jul 25, 2025

rerun ut

@chyezh
Copy link
Contributor Author

chyezh commented Jul 25, 2025

rerun ut

@chyezh
Copy link
Contributor Author

chyezh commented Jul 26, 2025

rerun ut

@chyezh chyezh force-pushed the fix_wrong_cp_metrics branch from 8b3b804 to 8dd0754 Compare July 26, 2025 03:33
@chyezh
Copy link
Contributor Author

chyezh commented Jul 26, 2025

rerun ut

@chyezh
fix: dirty cp metrics after drop
386dac8 
- The channel cp is dropped by garbage collector
- The channel is dropped and the cp is marked as math.Uint64
- If we drop it here, the update channel checkpoints will write the
  dirty cp back.

Signed-off-by: chyezh <[email protected]>
@chyezh chyezh force-pushed the fix_wrong_cp_metrics branch from 8dd0754 to 386dac8 Compare July 26, 2025 06:44
@chyezh
Copy link
Contributor Author

chyezh commented Jul 26, 2025

rerun ut

@mergify mergify bot added the ci-passed label Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@sunby sunby Awaiting requested review from sunby

Assignees
No one assigned
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chyezh @sre-ci-robot