enhance: support recalls for milvus_client #2552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chasingegg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chasingegg
force-pushed
the
recall-support
branch
2 times, most recently
from
1b06a72 to
485136e
Compare
This was referenced Jan 9, 2025
XuanYang-cn
reviewed
Jan 10, 2025
pymilvus/client/types.py
Outdated
|
|
||
| def __str__(self) -> str: | ||
| """Only print at most 10 query results""" | ||
| recall_msg = ( | ||
| f", recalls: {list(map(str, self.recalls))}" |
There was a problem hiding this comment.
might need to limit the printed max length to 10
chasingegg
force-pushed
the
recall-support
branch
from
485136e to
b1d826c
Compare
chasingegg
force-pushed
the
recall-support
branch
from
b1d826c to
c3dad23
Compare
Signed-off-by: chasingegg <[email protected]>
chasingegg
force-pushed
the
recall-support
branch
from
acb9a9f to
1c1d993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: milvus-io/milvus#37899