Skip to content

Conversation

@jac0626
Copy link
Collaborator

@jac0626 jac0626 commented Dec 9, 2025

  • Introduced TypeHandler strategy pattern to encapsulate type-specific logic in dedicated handlers
  • Refactored entity_helper.py and search_result.py, eliminating extensive if/elif branches
  • Added type_handlers module with scalar, vector, and complex handlers

also see #3134

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jac0626
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 73.66120% with 241 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@7ac0d68). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pymilvus/client/entity_helper.py 30.95% 87 Missing ⚠️
pymilvus/client/search_result.py 70.90% 48 Missing ⚠️
pymilvus/client/type_handlers/scalar_handlers.py 79.42% 43 Missing ⚠️
pymilvus/client/type_handlers/complex_handlers.py 72.64% 32 Missing ⚠️
pymilvus/client/type_handlers/vector_handlers.py 86.62% 21 Missing ⚠️
pymilvus/client/types.py 27.27% 8 Missing ⚠️
pymilvus/client/type_handlers/base.py 94.28% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3135   +/-   ##
=========================================
  Coverage          ?   50.41%           
=========================================
  Files             ?       73           
  Lines             ?    14093           
  Branches          ?        0           
=========================================
  Hits              ?     7105           
  Misses            ?     6988           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Dec 10, 2025
@jac0626 jac0626 force-pushed the refactor/type-handler-registry branch 7 times, most recently from 3a209a4 to 1f2c74a Compare December 11, 2025 04:02
@jac0626 jac0626 force-pushed the refactor/type-handler-registry branch from 1f2c74a to 2a60900 Compare December 11, 2025 04:40
@jac0626 jac0626 changed the title [WIP]refactor: refactor data process code refactor: refactor data process code Dec 11, 2025
@jac0626 jac0626 requested a review from XuanYang-cn December 11, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants