Skip to content

Conversation

@jac0626
Copy link
Collaborator

@jac0626 jac0626 commented Dec 11, 2025

  • Migrated connections.py, schema.py, iterator.py, types.py, constants.py from pymilvus/orm to pymilvus/client
  • Add deprecated warning while using orm
  • Maintained backward compatibility via re-exports in pymilvus/orm
  • Updated test imports (9 files) to use pymilvus.client
  • Added test_orm_deprecation.py for backward compatibility verification

also see #3133

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jac0626
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 49.84404% with 804 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@f01620e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pymilvus/client/iterator.py 22.87% 408 Missing ⚠️
pymilvus/client/schema.py 54.90% 317 Missing ⚠️
pymilvus/client/connections.py 75.62% 49 Missing ⚠️
pymilvus/client/types.py 66.66% 22 Missing ⚠️
pymilvus/orm/__init__.py 73.33% 4 Missing ⚠️
pymilvus/client/abstract.py 57.14% 3 Missing ⚠️
pymilvus/client/async_grpc_handler.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3138   +/-   ##
=========================================
  Coverage          ?   46.44%           
=========================================
  Files             ?       70           
  Lines             ?    14007           
  Branches          ?        0           
=========================================
  Hits              ?     6505           
  Misses            ?     7502           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants