Skip to content

Conversation

@jac0626
Copy link
Collaborator

@jac0626 jac0626 commented Dec 11, 2025

use refcount to avoid remove connection using by multi-clients
also see #3132

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jac0626
To complete the pull request process, please assign longjiquan after the PR has been reviewed.
You can assign the PR to them by writing /assign @longjiquan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@7ac0d68). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pymilvus/milvus_client/_utils.py 50.00% 1 Missing ⚠️
pymilvus/milvus_client/async_milvus_client.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3140   +/-   ##
=========================================
  Coverage          ?   46.51%           
=========================================
  Files             ?       66           
  Lines             ?    14012           
  Branches          ?        0           
=========================================
  Hits              ?     6518           
  Misses            ?     7494           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Dec 11, 2025
@jac0626 jac0626 requested a review from XuanYang-cn December 11, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants