Skip to content

Conversation

@marcelo-cjl
Copy link

  • Add None value handling in pack_field_value_to_field_data() for all vector types
  • Add get_physical_index() helper for logical-to-physical index mapping
  • Update extract_row_data_from_fields_data() with valid_data check and physical index mapping
  • Update HybridHits.materialize() and HybridExtraList._extract_lazy_fields() for nullable vectors
  • Update len_of() to use valid_data length as logical row count
  • Remove nullable restriction for vector fields in insert method

@sre-ci-robot sre-ci-robot requested review from czs007 and tedxu December 15, 2025 06:29
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marcelo-cjl
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- Add None value handling in pack_field_value_to_field_data() for all vector types
- Add get_physical_index() helper for logical-to-physical index mapping
- Update extract_row_data_from_fields_data() with valid_data check and physical index mapping
- Update HybridHits.materialize() and HybridExtraList._extract_lazy_fields() for nullable vectors
- Update len_of() to use valid_data length as logical row count
- Remove nullable restriction for vector fields in insert method

Signed-off-by: marcelo-cjl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants