[Do not Merge] Exploratory fix for PMMR header crash #3807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is here for testing and diagnosis only, for now.)
This is tryiong track down a capacity overflow panic reported in the keybase dev channel that can happen when a node receives PMMR segment data from a peer during PIBD sync. The code was blindly trusting the segment size announced by the peer and trying to allocate huge amounts of memory if that size was bogus (either intentionally malicious or just corrupted).
To fix / diagnose this, we're trying to:
This should help pinpoint where the error is coming from (whether it's an intentionally malicious peer or an error in the client code somewhere)