Optimize join tables from different databases: executor#10146
Merged
ZoranPandovski merged 6 commits intomainfrom Nov 14, 2024
Merged
Optimize join tables from different databases: executor#10146ZoranPandovski merged 6 commits intomainfrom
ZoranPandovski merged 6 commits intomainfrom
Conversation
StpMax
approved these changes
Nov 12, 2024
| if step.query.condition is None: | ||
| raise NotSupportedYet('Unable to join table without condition') | ||
| # prevent memory overflow | ||
| if len(left_data) * len(right_data) < 10 ** 7: |
Collaborator
There was a problem hiding this comment.
Are left_data and right_data dataframes? If so, then may be better to get real size (df.memory_usage(index=True, deep=True).sum()) and compare with free memory?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates:
Subselect step is used to get value from previous step data.
Next step is fetching data using these values as filter
Side fix:
If join is without condition:
0=0filter (multiply rows)Dependent on mindsdb/mindsdb_sql#412
Fixes #issue_number
Type of change
Verification Process
To ensure the changes are working as expected:
Additional Media:
Checklist: