Add content to the landing page #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSuperGamer20578
requested changes
Feb 3, 2025
layouts/_default/baseof.html
Outdated
| </body> | ||
| </html> | ||
|
|
||
| </html> |
There was a problem hiding this comment.
Missing newline at end of file.
layouts/_default/baseof.html
Outdated
| @ <a href="https://github.com/{{- getenv "GITHUB_REPOSITORY" -}}/commit/{{- . -}}"> | ||
| <abbr title="{{- . -}}">{{- . | truncate 9 "" -}}</abbr> | ||
| </a> | ||
| @ <a href="https://github.com/{{- getenv " GITHUB_REPOSITORY" -}}/commit/{{- . -}}"> |
There was a problem hiding this comment.
This extra space is going to be a problem.
There was a problem hiding this comment.
It looks like your auto-formatter doesn't understand Go Templates or you havn't told it that this is a Go Template.
|
Formatting should be correct now. Should I open a PR on the docs site to remove the duplicate pages? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
Note: Remove the downloads and faq pages from the docs site to avoid duplication
Edit: Also there should be a link on the docs page to the landing page. maybe label it as home and rename the current docs homepage to overview or something